remoting/proto/video.proto - Issue 10736046: Add DPI information to video packets.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/proto/video.proto

Issue 10736046: Add DPI information to video packets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « remoting/base/encoder_vp8_unittest.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Protocol for video messages.	5 // Protocol for video messages.

6	6

7 syntax = "proto2";	7 syntax = "proto2";

8	8

9 option optimize_for = LITE_RUNTIME;	9 option optimize_for = LITE_RUNTIME;

10	10

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87	87

88 // Time in milliseconds spent in capturing this video frame.	88 // Time in milliseconds spent in capturing this video frame.

89 optional int32 capture_time_ms = 7;	89 optional int32 capture_time_ms = 7;

90	90

91 // Time in milliseconds spent in encoding this video frame.	91 // Time in milliseconds spent in encoding this video frame.

92 optional int32 encode_time_ms = 8;	92 optional int32 encode_time_ms = 8;

93	93

94 // The most recent sequence number received from the client on the event	94 // The most recent sequence number received from the client on the event

95 // channel.	95 // channel.

96 optional int64 client_sequence_number = 9;	96 optional int64 client_sequence_number = 9;

	97

	98 // The DPI for this video packet.

	99 optional int32 dpi = 10;
	Sergey Ulanov 2012/07/12 01:39:36 would it be better to make this part of VideoPacke would it be better to make this part of VideoPacketFormat. That's what we use to send screen resolution. Wez 2012/07/12 18:15:49 Agreed; this is part of the format. Show quoted text On 2012/07/12 01:39:36, sergeyu wrote: > would it be better to make this part of VideoPacketFormat. That's what we use to > send screen resolution. Agreed; this is part of the format. Wez 2012/07/12 18:15:49 We should provide separate X & Y DPI values, so th We should provide separate X & Y DPI values, so that we can cope with weird pixel aspect in future. Jamie 2012/07/13 19:59:44 Done. Show quoted text On 2012/07/12 18:15:49, Wez wrote: > We should provide separate X & Y DPI values, so that we can cope with weird > pixel aspect in future. Done. Jamie 2012/07/13 19:59:44 Done. Show quoted text On 2012/07/12 01:39:36, sergeyu wrote: > would it be better to make this part of VideoPacketFormat. That's what we use to > send screen resolution. Done.
97 }	100 }

OLD	NEW