Allocate one extra line to allow for H264 chroma MC overreads.

media/base/video_frame.cc

Index: media/base/video_frame.cc
===================================================================
--- media/base/video_frame.cc	(revision 146165)
+++ media/base/video_frame.cc	(working copy)
@@ -135,7 +135,9 @@
                             kFrameSizeAlignment);
   size_t uv_stride = RoundUp(row_bytes(VideoFrame::kUPlane),
                              kFrameSizeAlignment);
-  size_t y_height = RoundUp(height_, kFrameSizeAlignment);
+  // the *2 here is because some formats (e.g. h264) allow interlaced coding,
+  // and then the size needs to be a multiple of two macroblocks (vertically).
+  size_t y_height = RoundUp(height_, kFrameSizeAlignment * 2);

[DaleCurtis, 2012/07/11 20:11:05]

The code you reference below adds 2 to the height after alignment.  Is this what
you intended?

   size_t uv_height = format_ == VideoFrame::YV12 ? y_height / 2 : y_height;
   size_t y_bytes = y_height * y_stride;
   size_t uv_bytes = uv_height * uv_stride;
@@ -143,8 +145,11 @@
 #if !defined(OS_ANDROID)
   // TODO(dalecurtis): use DataAligned or so, so this #ifdef hackery
   // doesn't need to be repeated in every single user of aligned data.
+  // The extra line of UV being allocates is because h264 chroma MC
+  // overreads by one line in some cases, see libavcodec/utils.c:244 or
+  // libavcodec/x86/h264_chromamc.asm:637).
   uint8* data = reinterpret_cast<uint8*>(
-      av_malloc(y_bytes + (uv_bytes * 2) + kFramePadBytes));
+      av_malloc(y_bytes + (uv_bytes * 2 + uv_stride) + kFramePadBytes));
 #else
   uint8* data = new uint8_t[y_bytes + (uv_bytes * 2)];
 #endif