Allocate one extra line to allow for H264 chroma MC overreads.

Allocate one extra line to allow for H264 chroma MC overreads.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146250

[rbultje1, 2012-07-11 19:38:53]

PTAL.

[DaleCurtis, 2012-07-11 20:11:05]

LGTM % Q.

https://chromiumcodereview.appspot.com/10736040/diff/1/media/base/video_frame.cc
File media/base/video_frame.cc (right):

https://chromiumcodereview.appspot.com/10736040/diff/1/media/base/video_frame...
media/base/video_frame.cc:140: size_t y_height = RoundUp(height_,
kFrameSizeAlignment * 2);
The code you reference below adds 2 to the height after alignment.  Is this what
you intended?

[rbultje1, 2012-07-11 20:46:26]

No, but I can add an extra comment. The *2 is for
http://git.libav.org/?p=libav.git;a=blob;f=libavcodec/utils.c;h=514a1f55696d3...

[scherkus (not reviewing), 2012-07-11 21:41:45]

nits on comments, LGTM

https://chromiumcodereview.appspot.com/10736040/diff/3002/media/base/video_fr...
File media/base/video_frame.cc (right):

https://chromiumcodereview.appspot.com/10736040/diff/3002/media/base/video_fr...
media/base/video_frame.cc:138: // the *2 here is because some formats (e.g.
h264) allow interlaced coding,
nit: Proper sentences (capitals, periods, etc. --> so s/the/The)

https://chromiumcodereview.appspot.com/10736040/diff/3002/media/base/video_fr...
media/base/video_frame.cc:140: // See libavcodec/utils.c:192.
is it possible to refer to functions + file name instead of source lines?

I imagine this comment will go out of date pretty quickly

https://chromiumcodereview.appspot.com/10736040/diff/3002/media/base/video_fr...
media/base/video_frame.cc:149: // The extra line of UV being allocates is
because h264 chroma MC
s/allocates/allocated/

https://chromiumcodereview.appspot.com/10736040/diff/3002/media/base/video_fr...
media/base/video_frame.cc:151: // libavcodec/x86/h264_chromamc.asm:637).
ditto

[commit-bot: I haz the power, 2012-07-11 21:48:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rbultje@chromium.org/10736040/7001

[commit-bot: I haz the power, 2012-07-12 00:30:25]

Change committed as 146250