Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1818)

Unified Diff: ppapi/proxy/ppb_flash_proxy.cc

Issue 10736039: Re-enabled PPAPI crash url for non-windows platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppb_flash_proxy.cc
diff --git a/ppapi/proxy/ppb_flash_proxy.cc b/ppapi/proxy/ppb_flash_proxy.cc
index 0badfe7bcbb2739f8f7321a144c1486610f5ec6b..df50196bb0e7467a15d873393b60f4e6232efed8 100644
--- a/ppapi/proxy/ppb_flash_proxy.cc
+++ b/ppapi/proxy/ppb_flash_proxy.cc
@@ -7,6 +7,7 @@
#include "base/logging.h"
#include "base/message_loop.h"
#include "base/time.h"
+#include "build/build_config.h"
#include "ppapi/c/dev/ppb_font_dev.h"
#include "ppapi/c/dev/ppb_var_deprecated.h"
#include "ppapi/c/pp_errors.h"
@@ -312,10 +313,12 @@ PP_Bool PPB_Flash_Proxy::SetCrashData(PP_Instance instance,
PP_Var value) {
switch (key) {
case PP_FLASHCRASHKEY_URL:
- // TODO(raymes): This may be breaking crash reporting, see:
+#if defined(OS_WIN)
+ // TODO(raymes): This may be breaking crash reporting on Windows, see:
// See https://code.google.com/p/chromium/issues/detail?id=135480.
// Disable temporarily.
return PP_FALSE;
+#endif
StringVar *url_string_var(StringVar::FromPPVar(value));
if (!url_string_var)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698