Issue 10736039: Re-enabled PPAPI crash url for non-windows platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10736039: Re-enabled PPAPI crash url for non-windows platforms. (Closed)

Created:
8 years, 5 months ago by raymes

Modified:
8 years, 5 months ago

Reviewers:
yzshen1, Scott Hess - ex-Googler

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Re-enabled PPAPI crash url for non-windows platforms. When this is enabled for windows, we stop getting crash reports. See https://code.google.com/p/chromium/issues/detail?id=135480 BUG=135480 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146199

Patch Set 3 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	ppapi/proxy/ppb_flash_proxy.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yzshen1

https://chromiumcodereview.appspot.com/10736039/diff/1/ppapi/proxy/ppb_flash_proxy.cc File ppapi/proxy/ppb_flash_proxy.cc (right): https://chromiumcodereview.appspot.com/10736039/diff/1/ppapi/proxy/ppb_flash_proxy.cc#newcode320 ppapi/proxy/ppb_flash_proxy.cc:320: #endif nit: it is better to use a #else ...

8 years, 5 months ago (2012-07-11 18:22:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/10736039/10001

8 years, 5 months ago (2012-07-11 18:55:48 UTC) #5

Change committed as 146199

Expand Messages | Collapse Messages

Issue 10736039: Re-enabled PPAPI crash url for non-windows platforms. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Messages