Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 10736036: IndexedDB: Re-enable browser layout tests for transactions following WK patches (Closed)

Created:
8 years, 5 months ago by jsbell
Modified:
8 years, 5 months ago
Reviewers:
michaeln, dgrogan
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, alecflett
Visibility:
Public.

Description

IndexedDB: Re-enable browser layout tests for transactions following WK patches The transaction-abort test was flaky in Chromium, fixed by WK90412/r122291. The others were disabled to allow landing WK89379/r121492 which renamed the tests. BUG=83226 TEST=browser_tests --gtest_filter='IndexedDBLayoutTest.TransactionTests' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M content/browser/in_process_webkit/indexed_db_layout_browsertest.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
dgrogan@ - please take a look? "Works on my machine" but I've submitted a try ...
8 years, 5 months ago (2012-07-11 17:23:53 UTC) #1
jsbell
On 2012/07/11 17:23:53, jsbell wrote: > "Works on my machine" but I've submitted a try ...
8 years, 5 months ago (2012-07-11 18:30:02 UTC) #2
dgrogan
lgtm
8 years, 5 months ago (2012-07-11 18:31:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/10736036/1
8 years, 5 months ago (2012-07-11 18:32:10 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 19:54:27 UTC) #5
Change committed as 146178

Powered by Google App Engine
This is Rietveld 408576698