Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 10736031: Update the WebKit API used for WebSurroundingText. (Closed)

Created:
8 years, 5 months ago by Leandro Graciá Gil
Modified:
8 years, 5 months ago
Reviewers:
abarth-chromium, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Update the WebKit API used for WebSurroundingText. With the update of the WebSurroundingText API and layout tests the currently exposed initialize methods can be simplified into one. Update Chromium to allow this happening without breaking the build. BUG=125390 TEST=end to end Android UI tests, not ready to be upstreamed yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/android/content_detector.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Leandro Graciá Gil
abarth: since you reviewed the WebKit API change, could you take a look to the ...
8 years, 5 months ago (2012-07-11 14:14:09 UTC) #1
piman
Owner LGTM, assuming it's ok with abarth. I assume this will have to go through ...
8 years, 5 months ago (2012-07-11 16:20:56 UTC) #2
abarth-chromium
LGTM
8 years, 5 months ago (2012-07-11 17:00:30 UTC) #3
Leandro Graciá Gil
On 2012/07/11 16:20:56, piman wrote: > Owner LGTM, assuming it's ok with abarth. > I ...
8 years, 5 months ago (2012-07-11 17:08:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/10736031/1
8 years, 5 months ago (2012-07-11 17:08:24 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 18:33:50 UTC) #6
Change committed as 146154

Powered by Google App Engine
This is Rietveld 408576698