Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1849)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 10736028: Refactor browser window zoom handling and enable zoom icon on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index 07c19b05e8d6e36e6f44d5fbfd8bc9a6ac99cbab..29262f570d5c10765ed20f2c2c496817719a428f 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -249,16 +249,10 @@ void BrowserWindowCocoa::SetStarredState(bool is_starred) {
[controller_ setStarredState:is_starred ? YES : NO];
}
-void BrowserWindowCocoa::SetZoomIconState(ZoomController::ZoomIconState state) {
- // TODO(khorimoto): Find someone to implement this.
-}
-
-void BrowserWindowCocoa::SetZoomIconTooltipPercent(int zoom_percent) {
- // TODO(khorimoto): Find someone to implement this.
-}
+void BrowserWindowCocoa::ZoomChangedForActiveTab(bool can_show_bubble) {
+ [controller_ zoomChangedForActiveTab:can_show_bubble ? YES : NO];
-void BrowserWindowCocoa::ShowZoomBubble(int zoom_percent) {
- // TODO(khorimoto): Find someone to implement this.
+ // TODO(dbeam): show a zoom bubble when when the wrench menu's not showing.
}
gfx::Rect BrowserWindowCocoa::GetRestoredBounds() const {

Powered by Google App Engine
This is Rietveld 408576698