Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 10736028: Refactor browser window zoom handling and enable zoom icon on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // OS_WIN 10 #endif // OS_WIN
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 #include "chrome/browser/ui/tab_contents/core_tab_helper.h" 136 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
137 #include "chrome/browser/ui/tab_contents/tab_contents.h" 137 #include "chrome/browser/ui/tab_contents/tab_contents.h"
138 #include "chrome/browser/ui/tabs/dock_info.h" 138 #include "chrome/browser/ui/tabs/dock_info.h"
139 #include "chrome/browser/ui/tabs/tab_menu_model.h" 139 #include "chrome/browser/ui/tabs/tab_menu_model.h"
140 #include "chrome/browser/ui/tabs/tab_strip_model.h" 140 #include "chrome/browser/ui/tabs/tab_strip_model.h"
141 #include "chrome/browser/ui/unload_controller.h" 141 #include "chrome/browser/ui/unload_controller.h"
142 #include "chrome/browser/ui/web_applications/web_app_ui.h" 142 #include "chrome/browser/ui/web_applications/web_app_ui.h"
143 #include "chrome/browser/ui/webui/signin/login_ui_service.h" 143 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
144 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h" 144 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
145 #include "chrome/browser/ui/window_sizer/window_sizer.h" 145 #include "chrome/browser/ui/window_sizer/window_sizer.h"
146 #include "chrome/browser/ui/zoom/zoom_controller.h"
146 #include "chrome/browser/upgrade_detector.h" 147 #include "chrome/browser/upgrade_detector.h"
147 #include "chrome/browser/web_applications/web_app.h" 148 #include "chrome/browser/web_applications/web_app.h"
148 #include "chrome/common/chrome_constants.h" 149 #include "chrome/common/chrome_constants.h"
149 #include "chrome/common/chrome_notification_types.h" 150 #include "chrome/common/chrome_notification_types.h"
150 #include "chrome/common/chrome_switches.h" 151 #include "chrome/common/chrome_switches.h"
151 #include "chrome/common/custom_handlers/protocol_handler.h" 152 #include "chrome/common/custom_handlers/protocol_handler.h"
152 #include "chrome/common/extensions/extension.h" 153 #include "chrome/common/extensions/extension.h"
153 #include "chrome/common/extensions/extension_constants.h" 154 #include "chrome/common/extensions/extension_constants.h"
154 #include "chrome/common/pref_names.h" 155 #include "chrome/common/pref_names.h"
155 #include "chrome/common/profiling.h" 156 #include "chrome/common/profiling.h"
(...skipping 1603 matching lines...) Expand 10 before | Expand all | Expand 10 after
1759 // Browser, BookmarkTabHelperDelegate implementation: 1760 // Browser, BookmarkTabHelperDelegate implementation:
1760 1761
1761 void Browser::URLStarredChanged(TabContents* source, bool starred) { 1762 void Browser::URLStarredChanged(TabContents* source, bool starred) {
1762 if (source == chrome::GetActiveTabContents(this)) 1763 if (source == chrome::GetActiveTabContents(this))
1763 window_->SetStarredState(starred); 1764 window_->SetStarredState(starred);
1764 } 1765 }
1765 1766
1766 /////////////////////////////////////////////////////////////////////////////// 1767 ///////////////////////////////////////////////////////////////////////////////
1767 // Browser, ZoomObserver implementation: 1768 // Browser, ZoomObserver implementation:
1768 1769
1769 void Browser::OnZoomIconChanged(TabContents* source, 1770 void Browser::OnZoomChanged(TabContents* source, bool can_show_bubble) {
1770 ZoomController::ZoomIconState state) {
1771 if (source == chrome::GetActiveTabContents(this))
1772 window_->SetZoomIconState(state);
1773 }
1774
1775 void Browser::OnZoomChanged(TabContents* source,
1776 int zoom_percent,
1777 bool can_show_bubble) {
1778 if (source == chrome::GetActiveTabContents(this)) { 1771 if (source == chrome::GetActiveTabContents(this)) {
1779 window_->SetZoomIconTooltipPercent(zoom_percent);
1780
1781 // Only show the zoom bubble for zoom changes in the active window. 1772 // Only show the zoom bubble for zoom changes in the active window.
1782 if (can_show_bubble && window_->IsActive()) 1773 window_->ZoomChangedForActiveTab(can_show_bubble && window_->IsActive());
1783 window_->ShowZoomBubble(zoom_percent);
1784 } 1774 }
1785 } 1775 }
1786 1776
1787 /////////////////////////////////////////////////////////////////////////////// 1777 ///////////////////////////////////////////////////////////////////////////////
1788 // Browser, ui::SelectFileDialog::Listener implementation: 1778 // Browser, ui::SelectFileDialog::Listener implementation:
1789 1779
1790 void Browser::FileSelected(const FilePath& path, int index, void* params) { 1780 void Browser::FileSelected(const FilePath& path, int index, void* params) {
1791 FileSelectedWithExtraInfo(ui::SelectedFileInfo(path, path), index, params); 1781 FileSelectedWithExtraInfo(ui::SelectedFileInfo(path, path), index, params);
1792 } 1782 }
1793 1783
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
2319 if (contents && !allow_js_access) { 2309 if (contents && !allow_js_access) {
2320 contents->web_contents()->GetController().LoadURL( 2310 contents->web_contents()->GetController().LoadURL(
2321 target_url, 2311 target_url,
2322 content::Referrer(), 2312 content::Referrer(),
2323 content::PAGE_TRANSITION_LINK, 2313 content::PAGE_TRANSITION_LINK,
2324 std::string()); // No extra headers. 2314 std::string()); // No extra headers.
2325 } 2315 }
2326 2316
2327 return contents != NULL; 2317 return contents != NULL;
2328 } 2318 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698