Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 10736027: Enhancement for gdb_content_shell, allow set package_name and shared_lib_dir (Closed)

Created:
8 years, 5 months ago by Shouqun Liu
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews, michaelbai
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enhancement for gdb_content_shell, allow package_name and shared_lib_dir to be set from arguments. This enables debug other pieces such as base_unittests_apk For example, to debug native tests, run with: gdb_apk -p org.chromium.native_test -l $CHROME_SRC/out/Release/lib.target -r BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146299

Patch Set 1 #

Patch Set 2 : Redirect gdb_content_shell to gdb_apk #

Patch Set 3 : Refine the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -84 lines) Patch
A + build/android/gdb_apk View 1 2 3 chunks +57 lines, -6 lines 0 comments Download
D build/android/gdb_content_shell View 1 1 chunk +5 lines, -78 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Shouqun Liu
Hi jrg, this patch enhances gdb_content_shell, make it can debug other apks (*_unittests_apk) with 'package_name' ...
8 years, 5 months ago (2012-07-11 08:34:50 UTC) #1
John Grabowski
LGTM! Can you keep the old shell script name, but just have it redirect to ...
8 years, 5 months ago (2012-07-11 17:57:20 UTC) #2
Shouqun Liu
On 2012/07/11 17:57:20, John Grabowski wrote: > LGTM! > > Can you keep the old ...
8 years, 5 months ago (2012-07-12 02:43:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10736027/4001
8 years, 5 months ago (2012-07-12 05:06:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10736027/6002
8 years, 5 months ago (2012-07-12 06:59:47 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 08:16:26 UTC) #6
Change committed as 146299

Powered by Google App Engine
This is Rietveld 408576698