Issue 10736021: Reland r145965 - Make sure previous seek points in SourceBufferStream are ignored during overlaps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10736021: Reland r145965 - Make sure previous seek points in SourceBufferStream are ignored during overlaps (Closed)

Created:
8 years, 5 months ago by vrk (LEFT CHROMIUM)

Modified:
8 years, 5 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland r145965 - Make sure previous seek points in SourceBufferStream are ignored during overlaps BUG=NONE TEST=asan bots are now happy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146181

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -13 lines)			Patch
M	media/filters/source_buffer_stream.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	media/filters/source_buffer_stream.cc	View	1	14 chunks	+49 lines, -13 lines	0 comments	Download
M	media/filters/source_buffer_stream_unittest.cc	View		1 chunk	+136 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

vrk (LEFT CHROMIUM)

The original CL got reverted because it introduced a use-after-free: after ResolveEndOverlap(), selected_range_ is still ...

8 years, 5 months ago (2012-07-11 17:23:50 UTC) #1

LGTM