content/zygote/zygote_libc_override_linux.h - Issue 10736017: Share the zygote's fopen overrides with nacl_helper.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/zygote/zygote_libc_override_linux.h

Issue 10736017: Share the zygote's fopen overrides with nacl_helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_ZYGOTE_ZYGOTE_LIBC_OVERRIDE_LINUX_H_
	Sergey Ulanov 2012/07/10 22:42:04 not sure if this is the best location for this fil not sure if this is the best location for this file. Might be better to put it in content/common and remove zygote from the name (it's not zygote specific now). Nick Bray (chromium) 2012/07/11 00:06:11 Done. Show quoted text On 2012/07/10 22:42:04, sergeyu wrote: > not sure if this is the best location for this file. Might be better to put it > in content/common and remove zygote from the name (it's not zygote specific > now). Done.
	6 #define CONTENT_ZYGOTE_ZYGOTE_LIBC_OVERRIDE_LINUX_H_

	7

	8 namespace content {

	9

	10 #if !defined(CHROMIUM_SELINUX)

	11

	12 // Used to control if calls to libc are intercepted or not.

	13 extern bool g_am_zygote_or_renderer;
	Sergey Ulanov 2012/07/10 22:42:04 instead of exposing this variable it's better to h instead of exposing this variable it's better to have a function that would set this flag (e.g. InitUrandomLibcOverrides()) to make sure we don't reset it flag to false by accident. Nick Bray (chromium) 2012/07/11 00:06:11 Done. Show quoted text On 2012/07/10 22:42:04, sergeyu wrote: > instead of exposing this variable it's better to have a function that would set > this flag (e.g. InitUrandomLibcOverrides()) to make sure we don't reset it flag > to false by accident. Done.
	14

	15 #endif
	Sergey Ulanov 2012/07/10 22:42:04 // !defined (CHROMIUM_SELINUX) // !defined (CHROMIUM_SELINUX) Nick Bray (chromium) 2012/07/11 00:06:11 Done. Show quoted text On 2012/07/10 22:42:04, sergeyu wrote: > // !defined (CHROMIUM_SELINUX) Done.
	16

	17 }
	Sergey Ulanov 2012/07/10 22:42:04 // namespace content // namespace content Nick Bray (chromium) 2012/07/11 00:06:11 Done. Show quoted text On 2012/07/10 22:42:04, sergeyu wrote: > // namespace content Done.
	18

	19 #endif // CONTENT_ZYGOTE_ZYGOTE_LIBC_OVERRIDE_LINUX_H_

OLD	NEW

« no previous file with comments | « content/content_browser.gypi ('k') | content/zygote/zygote_libc_override_linux.cc » ('j') | content/zygote/zygote_libc_override_linux.cc » ('J')