Issue 10736012: Disable SucceedWhenAllowed due to timeouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10736012: Disable SucceedWhenAllowed due to timeouts. (Closed)

Created:
8 years, 5 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 5 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, scheib+watch_chromium.org, ericu

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable SucceedWhenAllowed due to timeouts. BUG=136548 TBR=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145915

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ppapi/tests/test_mouse_lock.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yzshen1

LGTM https://chromiumcodereview.appspot.com/10736012/diff/1/ppapi/tests/test_mouse_lock.cc File ppapi/tests/test_mouse_lock.cc (right): https://chromiumcodereview.appspot.com/10736012/diff/1/ppapi/tests/test_mouse_lock.cc#newcode27 ppapi/tests/test_mouse_lock.cc:27: // Disabled due to timeouts: http://crbug.com/136548 The better ...

8 years, 5 months ago (2012-07-10 18:20:05 UTC) #2

Mihai Parparita -not on Chrome

8 years, 5 months ago (2012-07-10 19:17:01 UTC) #3

On 2012/07/10 18:20:05, yzshen1 wrote:
> The better way is to disable it in
> src/chrome/test/ppapi/ppapi_interactive_browsertest.cc
> (But I am fine with this now that it has been committed.)

Actually, I think this is needed, since otherwise you get stuff like:

../../chrome/test/ppapi/ppapi_test.cc:241: Failure
Value of: observer.result().c_str()
  Actual: "No tests executed. The test filter might be too restrictive:
'SucceedWhenAllowed'."
Expected: "PASS"

(from
http://build.chromium.org/p/chromium/builders/Mac%2010.6%20Tests%20%28dbg%29%...)

Sent out https://chromiumcodereview.appspot.com/10695127

Expand Messages | Collapse Messages