gclient_utils.py - Issue 10736011: Improve comment added in r145396.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient_utils.py

Issue 10736011: Improve comment added in r145396. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gclient_utils.py

diff --git a/gclient_utils.py b/gclient_utils.py

index 34f3db84719e2013ae8168a147eeb4eea968dca7..b413a88eb8a5d9150126e057c3ed7fd67787fe02 100644

--- a/gclient_utils.py

+++ b/gclient_utils.py

@@ -78,7 +78,8 @@ class PrintableObject(object):

def FileRead(filename, mode='rU'):

with open(filename, mode=mode) as f:

- # codecs.open() has different behavior than open() on python 2.6.

+ # codecs.open() has different behavior than open() on python 2.6 so use

+ # open() and decode manually.

return f.read().decode('utf-8')

« no previous file with comments | « no previous file | no next file » | no next file with comments »