Fix inline constructors for Harmony Proxy prototypes.

Fix inline constructors for Harmony Proxy prototypes.

R=rossberg@chromium.org
BUG=v8:2225
TEST=mjsunit/regress/regress-2225

Committed: https://code.google.com/p/v8/source/detail?r=12028

[rossberg, 2012-07-10 11:08:14]

LGTM with comments.

https://chromiumcodereview.appspot.com/10736009/diff/1/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10736009/diff/1/src/objects.cc#newcode...
src/objects.cc:4864: obj != heap->null_value();
While you're at it, can you replace this with !obj->IsNull()? (And likewise in a
couple of places below.)

https://chromiumcodereview.appspot.com/10736009/diff/1/src/objects.cc#newcode...
src/objects.cc:7799: if (!prototype->IsJSReceiver()) {
Do we still need this conditional at all? AFAICS, it is subsumed by the loop
condition below.

[Michael Starzinger, 2012-07-10 11:24:50]

Comments addressed. Landing.

https://chromiumcodereview.appspot.com/10736009/diff/1/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10736009/diff/1/src/objects.cc#newcode...
src/objects.cc:4864: obj != heap->null_value();
On 2012/07/10 11:08:14, rossberg wrote:
> While you're at it, can you replace this with !obj->IsNull()? (And likewise in
a
> couple of places below.)

As discussed offline: I'll keep the pointer comparison here, because it's more
efficient than the IsNull() predicate for cases where we already have the heap.

https://chromiumcodereview.appspot.com/10736009/diff/1/src/objects.cc#newcode...
src/objects.cc:7799: if (!prototype->IsJSReceiver()) {
On 2012/07/10 11:08:14, rossberg wrote:
> Do we still need this conditional at all? AFAICS, it is subsumed by the loop
> condition below.

Done.