Added reload drop-down menu for the Reload button on Linux when in the DevTools mode.

Added reload drop-down menu for the Reload button on Linux when in the DevTools mode.
When on the tab with DevTools opened, Reload button of the browser will behave similar
to Back button. Simple click will still perform default reload. Long click, right click
or click and move down will bring up drop-down menu and allow user to specify Normal,
Hard or Clear Cache and Hard Reload.
This is Linux only UI change now. Win and Mac will follow after commiting this CL.

BUG=136670
TEST=Open webpage. Bring up DevTools. Verify Reload button behavior.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146340

[gene, 2012-07-10 09:31:13]

Pavel, Patrick could you please take a look at this CL implementing Reload menu
in the DevTools mode.

+erg, estade for GTK changes
+ben for browser/ui changes

[pfeldman, 2012-07-10 16:24:53]

DevTools and general plumbing looks good.
- needs someone from the GTK side to review the UI changes
- needs owners for chrome/browser and chrome/browser/ui for owners approval.

[pfeldman, 2012-07-10 16:44:56]

https://chromiumcodereview.appspot.com/10736008/diff/1/chrome/browser/ui/brow...
File chrome/browser/ui/browser.cc (right):

https://chromiumcodereview.appspot.com/10736008/diff/1/chrome/browser/ui/brow...
chrome/browser/ui/browser.cc:573: return
content::DevToolsAgentHostRegistry::IsDebuggerAttached(
IsDebuggerAttached won't handle 0 web contents.

https://chromiumcodereview.appspot.com/10736008/diff/1/chrome/browser/ui/brow...
File chrome/browser/ui/browser.h (right):

https://chromiumcodereview.appspot.com/10736008/diff/1/chrome/browser/ui/brow...
chrome/browser/ui/browser.h:305: bool IsDebuggerAttachedForCurrentTab() const;
IsDebuggerAttachedToCurrentTab ?

[gene, 2012-07-10 17:10:11]

done, please take a look

[Elliot Glaysher, 2012-07-10 17:12:31]

gtk lgtm

I do wonder if this is discoverable.

[gene, 2012-07-10 17:41:56]

OWNERS, could you please take a look?

+ cpu@ for chrome/app/generated_resources.grd
+ ben@ or sky@ for chrome/browser/ui/

[Patrick Dubroy, 2012-07-10 17:56:06]

On 2012/07/10 17:41:56, gene wrote:
> OWNERS, could you please take a look?
> 
> + cpu@ for chrome/app/generated_resources.grd
> + ben@ or sky@ for chrome/browser/ui/

Can you send me a screenshot of what the menu looks like?

[Ben Goodger (Google), 2012-07-10 17:57:50]

1. is this already implemented on other platforms?
2. no api on Browser. use browser_commands.cc

[Ben Goodger (Google), 2012-07-10 17:58:16]

On 2012/07/10 17:57:50, Ben Goodger (Google) wrote:
> 1. is this already implemented on other platforms?
> 2. no api on Browser. use browser_commands.cc

I see answer to #1 now.

BTW, was this behavior approved by ui-leads?

[gene1, 2012-07-10 18:06:23]

1. Not yet. I wanted to implement first on Linux and make sure all the
plumbing is done the right way.
2. Will do.

This will be show ONLY when dev tools windows is open. I am following
Marcin's mocks for UI.

On Tue, Jul 10, 2012 at 9:58 PM, <ben@chromium.org> wrote:

> On 2012/07/10 17:57:50, Ben Goodger (Google) wrote:
>
>> 1. is this already implemented on other platforms?
>> 2. no api on Browser. use browser_commands.cc
>>
>
> I see answer to #1 now.
>
> BTW, was this behavior approved by ui-leads?
>
>
https://chromiumcodereview.**appspot.com/10736008/<https://chromiumcodereview...
>

[gene, 2012-07-10 20:23:46]

On 2012/07/10 17:57:50, Ben Goodger (Google) wrote:
> 1. is this already implemented on other platforms?
> 2. no api on Browser. use browser_commands.cc

2. Done. Please take a look.

[Evan Stade, 2012-07-11 02:13:30]

erg's LGTM stands for me.

https://chromiumcodereview.appspot.com/10736008/diff/1010/chrome/browser/ui/g...
File chrome/browser/ui/gtk/reload_button_gtk.cc (right):

https://chromiumcodereview.appspot.com/10736008/diff/1010/chrome/browser/ui/g...
chrome/browser/ui/gtk/reload_button_gtk.cc:425: if (browser_) {
no curlies

[Peter Kasting, 2012-07-11 02:16:30]

Why only when dev tools are open?  This can be useful at other times as well. 
We don't have any precedent for dev tools acting like an "enable power tools"
switch.  I'd prefer to just enable this all the time.

[Evan Stade, 2012-07-11 02:19:53]

yea, there definitely should be a bug filed for this feature to track product
questions like Peter's, cross-platform implementation, etc.

[gene, 2012-07-11 07:39:32]

Done.

[gene, 2012-07-11 08:04:24]

Sounds good to me.
Let's do DevTools on all platforms first (since they benefit the most), and then
switching for everyone will be a simple 3-line change? We can also fine-tune and
get feedback while feature is in DevTools only.

[gene, 2012-07-11 08:04:36]

On 2012/07/11 02:19:53, Evan Stade wrote:
> yea, there definitely should be a bug filed for this feature to track product
> questions like Peter's, cross-platform implementation, etc.

Will do.

[gene, 2012-07-11 10:06:59]

BUG field updated,
http://code.google.com/p/chromium/issues/detail?id=136670

[gene, 2012-07-11 15:55:30]

Got ok from Glen on keeping this functionality only when DevTools are present
for now.

[Ben Goodger (Google), 2012-07-11 16:14:31]

lgtm

https://chromiumcodereview.appspot.com/10736008/diff/9008/chrome/browser/ui/b...
File chrome/browser/ui/browser_commands.cc (right):

https://chromiumcodereview.appspot.com/10736008/diff/9008/chrome/browser/ui/b...
chrome/browser/ui/browser_commands.cc:866: return contents != NULL ?
contents ?

[gene, 2012-07-11 16:39:28]

Done.

[commit-bot: I haz the power, 2012-07-12 13:05:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10736008/1011

[commit-bot: I haz the power, 2012-07-12 13:05:33]

Failed to apply patch for chrome/browser/ui/gtk/reload_button_gtk.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/gtk/reload_button_gtk.cc
Hunk #2 FAILED at 22.
Hunk #3 succeeded at 28 (offset -1 lines).
Hunk #4 succeeded at 53 (offset -1 lines).
Hunk #5 succeeded at 76 (offset -1 lines).
Hunk #6 succeeded at 122 (offset -1 lines).
Hunk #7 succeeded at 175 (offset -1 lines).
Hunk #8 succeeded at 262 (offset -1 lines).
Hunk #9 succeeded at 290 (offset -1 lines).
Hunk #10 succeeded at 395 (offset -1 lines).
1 out of 10 hunks FAILED -- saving rejects to file
chrome/browser/ui/gtk/reload_button_gtk.cc.rej

[commit-bot: I haz the power, 2012-07-12 13:07:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10736008/1012

[commit-bot: I haz the power, 2012-07-12 14:24:40]

Change committed as 146340