Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 10736006: Fix OMX VDA unittest for ARM. (Closed)

Created:
8 years, 5 months ago by Pawel Osciak
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Base URL:
https://git.chromium.org/git/chromium/src@master
Visibility:
Public.

Description

Fix OMX VDA unittest for ARM. This fixes a segfault due to presumably invalid GL bindings. Also add CHECKs verifying we were able to acquire display, which otherwise would end up being cryptic segfaults as well. BUG=136292 TEST=Manual runs on ARM and CrOS x86. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145999

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M content/common/gpu/media/rendering_helper_gl.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Pawel Osciak
Removing the ui/gl dependency for ARM as well.
8 years, 5 months ago (2012-07-08 22:36:54 UTC) #1
Ami GONE FROM CHROMIUM
I'm pretty sure the BUG in the CL description is copy/pasta. Also the SHA1 doesn't ...
8 years, 5 months ago (2012-07-09 00:09:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/10736006/2001
8 years, 5 months ago (2012-07-09 00:27:57 UTC) #3
commit-bot: I haz the power
Presubmit check for 10736006-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-09 00:27:59 UTC) #4
Pawel Osciak
Brettw: please owners-review.
8 years, 5 months ago (2012-07-09 00:36:34 UTC) #5
brettw
lgtm
8 years, 5 months ago (2012-07-10 20:36:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/10736006/2001
8 years, 5 months ago (2012-07-10 20:39:39 UTC) #7
commit-bot: I haz the power
Try job failure for 10736006-2001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-10 22:21:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/10736006/2001
8 years, 5 months ago (2012-07-10 22:25:10 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 00:03:26 UTC) #10
Change committed as 145999

Powered by Google App Engine
This is Rietveld 408576698