Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: content/browser/download/download_item_impl.cc

Issue 10735089: DownloadManager::Observer::OnDownloadCreated (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.cc
diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc
index a3e72ffa469e50f0efd18f92c63a50c2a99e0e16..6f168fb0d81eb8223df6130c517543c30b8db1fd 100644
--- a/content/browser/download/download_item_impl.cc
+++ b/content/browser/download/download_item_impl.cc
@@ -604,7 +604,6 @@ void DownloadItemImpl::SetDangerType(content::DownloadDangerType danger_type) {
net::NetLog::TYPE_DOWNLOAD_ITEM_SAFETY_STATE_UPDATED,
base::Bind(&download_net_logs::ItemCheckedCallback,
GetDangerType(), GetSafetyState()));
- UpdateObservers();
}
}
@@ -871,7 +870,6 @@ void DownloadItemImpl::OnTargetPathDetermined(
const FilePath& target_path,
TargetDisposition disposition,
content::DownloadDangerType danger_type) {
- // TODO(rdsmith): Change to DCHECK after http://crbug.com/85408 resolved.
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
target_path_ = target_path;
target_disposition_ = disposition;
@@ -886,10 +884,10 @@ void DownloadItemImpl::OnTargetPathSelected(const FilePath& target_path) {
void DownloadItemImpl::OnContentCheckCompleted(
content::DownloadDangerType danger_type) {
- // TODO(rdsmith): Change to DCHECK after http://crbug.com/85408 resolved.
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(AllDataSaved());
SetDangerType(danger_type);
+ UpdateObservers();
}
void DownloadItemImpl::OnIntermediatePathDetermined(

Powered by Google App Engine
This is Rietveld 408576698