Issue 10735074: Moving input_ime to api/ .

Issue 10735074: Moving input_ime to api/ . (Closed)

Created:
8 years, 5 months ago by vabr (Chromium)

Modified:
8 years, 5 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, yusukes+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Moving input_ime to api/ . BUG=101244 TEST=N/A, only moving code, no change in functionality Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148093

Patch Set 5 : Dropping Extension prefix from InputImeEventRouter #

Patch Set 6 : Indentation #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -1085 lines)			Patch
A +	chrome/browser/extensions/api/input_ime/input_ime_api.h	View	1 2 3 4	5 chunks	+13 lines, -9 lines	0 comments	Download
A +	chrome/browser/extensions/api/input_ime/input_ime_api.cc	View	1 2 3 4 5	17 chunks	+28 lines, -32 lines	0 comments	Download
A +	chrome/browser/extensions/api/input_ime/input_ime_apitest_chromeos.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_registry.cc	View	1 2 3 4 5	2 chunks	+11 lines, -11 lines	0 comments	Download
D	chrome/browser/extensions/extension_input_ime_api.h	View		1 chunk	+0 lines, -171 lines	0 comments	Download
D	chrome/browser/extensions/extension_input_ime_api.cc	View	1 2 3 4	1 chunk	+0 lines, -837 lines	0 comments	Download
D	chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	1 2 3 4	5 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2 3 4	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vabr (Chromium)

Hi Aaron, Could you please review this? This API is ChromeOS-specific, so I am not ...

8 years, 5 months ago (2012-07-12 17:37:56 UTC) #1

vabr (Chromium)

Hi Aaron, This is a friendly ping about this review. :) Cheers, Vaclav

8 years, 5 months ago (2012-07-18 07:23:43 UTC) #2

vabr (Chromium)

On 2012/07/18 07:23:43, vabr (Chromium) wrote: > Hi Aaron, > > This is a friendly ...

8 years, 5 months ago (2012-07-23 07:10:53 UTC) #3

Aaron Boodman

So sorry. LGTM w/ nit. http://codereview.chromium.org/10735074/diff/9001/chrome/browser/extensions/api/input_ime/input_ime_api.h File chrome/browser/extensions/api/input_ime/input_ime_api.h (right): http://codereview.chromium.org/10735074/diff/9001/chrome/browser/extensions/api/input_ime/input_ime_api.h#newcode28 chrome/browser/extensions/api/input_ime/input_ime_api.h:28: class ExtensionInputImeEventRouter { The ...

8 years, 5 months ago (2012-07-23 23:48:41 UTC) #4

vabr (Chromium)

Thanks very much! I dropped the Extension as suggested, and am sending this to CQ. ...

8 years, 5 months ago (2012-07-24 10:02:15 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/10735074/17001

8 years, 5 months ago (2012-07-24 10:02:56 UTC) #6

Change committed as 148093

Expand Messages | Collapse Messages