runtime/vm/flow_graph_optimizer.cc - Issue 10735071: Introduce Goto instructions to the flow graph.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10735071: Introduce Goto instructions to the flow graph. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rewrite a comment that was word salad. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_optimizer.cc

diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc

index c90c67ff0af2d17f04722bd7c69af0fa948dd09b..c3b3cda38488bf63dfd2eddaabceb80ce2b466d9 100644

--- a/runtime/vm/flow_graph_optimizer.cc

+++ b/runtime/vm/flow_graph_optimizer.cc

@@ -555,8 +555,7 @@ static void TryFuseComparisonWithBranch(BindInstr* instr,

comp->MarkFusedWithBranch(branch);

branch->MarkFusedWithComparison(comp);

branch->set_is_negated(true);

- // Remove comparison and boolean negation from the graph.

+ // Remove the comparison and the boolean negation from the graph.

branch->set_previous(instr->previous());

instr->previous()->set_next(branch);

return;