gdata cleanup: Make GDataFileSystem::AddUploadedFile() take scoped_ptr<DocumentEntry>.

gdata cleanup: Make GDataFileSystem::AddUploadedFile() take scoped_ptr<DocumentEntry>.

Previously this function takes a DocumentEntry* pointer obtained from UploadFileInfo.
This implicitly requires caller to keep the DocumentEntry object (or the UploadFileInfo
struct) alive until the call is complete.

Changing this argument to a scoped pointer makes ownership transfer explicit.

BUG=none
TEST=unit_tests (GData*), lumpy

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146190

[hshi1, 2012-07-11 18:06:17]

PTAL. Clean-up only, no functional change.

[achuithb, 2012-07-11 18:56:22]

lgtm. Thanks for the cleanup! This is much better.

http://codereview.chromium.org/10735059/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right):

http://codereview.chromium.org/10735059/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_download_observer.cc:522: // Take ownership
of the DocumentEntry object. It will be released upon
Maybe update this statement to note that ownership is passed on to
AddUploadedFile.

[satorux1, 2012-07-11 19:17:16]

LGTM. Not being able to mockable is unfortunate, but overall, removing the
brittle pieces of code is a good thing to do.

http://codereview.chromium.org/10735059/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (left):

http://codereview.chromium.org/10735059/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:1171: const UploadFileInfo*
upload_file_info_ptr = upload_file_info.get();
glad to see this brittle piece to be gone.

http://codereview.chromium.org/10735059/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2391: const UploadFileInfo*
upload_file_info_ptr = upload_file_info.get();
this one too.

[hshi1, 2012-07-11 19:25:44]

http://codereview.chromium.org/10735059/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_download_observer.cc (right):

http://codereview.chromium.org/10735059/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_download_observer.cc:522: // Take ownership
of the DocumentEntry object. It will be released upon
On 2012/07/11 18:56:22, achuith.bhandarkar wrote:
> Maybe update this statement to note that ownership is passed on to
> AddUploadedFile.

Done.

[commit-bot: I haz the power, 2012-07-11 19:26:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/10735059/6