lib/compiler/implementation/ssa/types_propagation.dart - Issue 10735051: Fix usage of UNKNOWN/CONFLICTING types for union.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/types_propagation.dart

Issue 10735051: Fix usage of UNKNOWN/CONFLICTING types for union. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Cosmetic change in comment. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/ssa/types_propagation.dart

diff --git a/lib/compiler/implementation/ssa/types_propagation.dart b/lib/compiler/implementation/ssa/types_propagation.dart

index f83b25b7d28dc2d93c8b0989d088fa2634a675e0..4f05db699a58469e7ce4048f8fe45d1bd1c29e0a 100644

--- a/lib/compiler/implementation/ssa/types_propagation.dart

+++ b/lib/compiler/implementation/ssa/types_propagation.dart

@@ -65,7 +65,7 @@ class SsaTypePropagator extends HGraphVisitor implements OptimizationPhase {

visitBasicBlock(HBasicBlock block) {

if (block.isLoopHeader()) {

block.forEachPhi((HPhi phi) {

- // Once the propagation has run once the propagated type can already

+ // Once the propagation has run once, the propagated type can already

// be set. In this case we use that one for the first iteration of the

// loop.

if (phi.propagatedType.isUnknown()) {