Issue 10735049: gdata: Take GDataCache::CacheEntry as parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10735049: gdata: Take GDataCache::CacheEntry as parameters (Closed)

Created:
8 years, 5 months ago by satorux1

Modified:
8 years, 5 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Take GDataCache::CacheEntry as parameters Change GDataCache::UpdateCacheWithSubDirectoryType() and GDataCacheMetadata::UpdateCache() to take CacheEntry. This is in preparation for removing IsCache/SetCache/ClearCache* functions from GDataCache. BUG=136625 TEST=out/Release/unit_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146179

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -42 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_cache.h	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache.cc	View	1 2	7 chunks	+12 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache_metadata.h	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache_metadata.cc	View		1 chunk	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc	View		5 chunks	+15 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm with two requests: 1) Please fix the change description to clarify which methods are ...

8 years, 5 months ago (2012-07-11 10:47:11 UTC) #2

satorux1

8 years, 5 months ago (2012-07-11 19:32:02 UTC) #3

On 2012/07/11 10:47:11, hashimoto wrote:
> lgtm with two requests:
> 
> 1) Please fix the change description to clarify which methods are taking
> CacheEntry as parameters.

Done.

> 2) Could you remove UpdateCacheWithSubDirectoryType() in this change or later?

> All user code of the method may be easily rewritten with UpdateCache().

Good idea. Will do it at a later time in a separate patch.

Expand Messages | Collapse Messages

Issue 10735049: gdata: Take GDataCache::CacheEntry as parameters (Closed)

Description

Patch Set 1 #

Patch Set 2 : polish #

Patch Set 3 : polish #

Messages