Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 10735043: Exclude extension_settings_handler.cc from android build. (Closed)

Created:
8 years, 5 months ago by nilesh
Modified:
8 years, 5 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude extension_settings_handler.cc from android build. It depends on ManagaedMode (which is excluded on android). BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nilesh
8 years, 5 months ago (2012-07-11 00:44:37 UTC) #1
Jay Civelli
lgtm
8 years, 5 months ago (2012-07-11 17:30:44 UTC) #2
nilesh
John, Can you please take a look for OWNERS approval.
8 years, 5 months ago (2012-07-11 17:43:27 UTC) #3
jam
On 2012/07/11 17:43:27, nileshagrawal1 wrote: > John, Can you please take a look for OWNERS ...
8 years, 5 months ago (2012-07-11 20:39:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10735043/1
8 years, 5 months ago (2012-07-11 20:44:10 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 23:38:28 UTC) #6
Change committed as 146240

Powered by Google App Engine
This is Rietveld 408576698