Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 10735042: Revert 145969 - Removing last usage of default request context. Fixing up login_utils to not need i… (Closed)

Created:
8 years, 5 months ago by rpetterson
Modified:
8 years, 5 months ago
Reviewers:
rpetterson
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 145969 - Removing last usage of default request context. Fixing up login_utils to not need it by adding a notification so that login_utils only accesses it when the request context getter has been initialized. BUG=125292, 127693 TEST=unittest, manual Review URL: https://chromiumcodereview.appspot.com/10657009 TBR=rlp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -73 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 9 chunks +5 lines, -56 lines 0 comments Download
M chrome/browser/profiles/profile.h View 3 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rpetterson
8 years, 5 months ago (2012-07-10 23:52:52 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698