Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: sync/syncable/syncable_proto_util.cc

Issue 10735041: Remove syncproto.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address most comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/syncable/syncable_proto_util.h ('k') | sync/syncable/syncable_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "sync/syncable/syncable_proto_util.h"
6
7 #include "sync/protocol/sync.pb.h"
8
9 namespace syncer {
10
11 syncable::Id SyncableIdFromProto(const std::string& proto_string) {
12 return syncable::Id::CreateFromServerId(proto_string);
13 }
14
15 std::string SyncableIdToProto(const syncable::Id& syncable_id) {
16 return syncable_id.GetServerId();
17 }
18
19 bool IsFolder(const sync_pb::SyncEntity& entity) {
20 // TODO(sync): The checks for has_folder() and has_bookmarkdata() are likely
21 // no longer necessary. We should remove them if we can convince ourselves
22 // that doing so won't break anything.
23 return ((entity.has_folder() && entity.folder()) ||
24 (entity.has_bookmarkdata() &&
25 entity.bookmarkdata().bookmark_folder()));
26 }
27
28 bool IsRoot(const sync_pb::SyncEntity& entity) {
29 return SyncableIdFromProto(entity.id_string()).IsRoot();
30 }
31
32 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/syncable/syncable_proto_util.h ('k') | sync/syncable/syncable_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698