Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 10735037: Add WebURLLoaderMockFactory::GetLastHandledAsynchronousRequest. (Closed)

Created:
8 years, 5 months ago by viettrungluu
Modified:
8 years, 5 months ago
Reviewers:
brettw, abarth-chromium
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add WebURLLoaderMockFactory::GetLastHandledAsynchronousRequest. This provides a way of getting the last request that was actually (mock) served, so that WebKit unit tests can, e.g., inspect headers that were "actually" sent out. BUG=http://crbug.com/134615 and https://bugs.webkit.org/show_bug.cgi?id=90893 TEST=see WebKit bug (forthcoming WebKit unit test) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M webkit/support/webkit_support.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/support/weburl_loader_mock_factory.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/support/weburl_loader_mock_factory.cc View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
8 years, 5 months ago (2012-07-10 20:55:21 UTC) #1
viettrungluu
+brettw, since I'll need an owner anyway
8 years, 5 months ago (2012-07-10 21:03:38 UTC) #2
abarth-chromium
Yeah, you probably want brettw or tony.
8 years, 5 months ago (2012-07-10 21:04:04 UTC) #3
brettw
8 years, 5 months ago (2012-07-10 21:19:16 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698