Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2535)

Unified Diff: chrome/browser/ui/gtk/gtk_theme_service.cc

Issue 10735034: Linux: Detect Unity as a desktop environment. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: add a comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/gtk_theme_service.cc
===================================================================
--- chrome/browser/ui/gtk/gtk_theme_service.cc (revision 146030)
+++ chrome/browser/ui/gtk/gtk_theme_service.cc (working copy)
@@ -617,11 +617,17 @@
switch (base::nix::GetDesktopEnvironment(env.get())) {
case base::nix::DESKTOP_ENVIRONMENT_GNOME:
+ case base::nix::DESKTOP_ENVIRONMENT_UNITY:
case base::nix::DESKTOP_ENVIRONMENT_XFCE:
return true;
- default:
+ case base::nix::DESKTOP_ENVIRONMENT_KDE3:
+ case base::nix::DESKTOP_ENVIRONMENT_KDE4:
+ case base::nix::DESKTOP_ENVIRONMENT_OTHER:
return false;
}
+ // g++ can't figure out the switch statement has all cases covered.
Mike Mammarella 2012/07/12 01:15:55 Technically, it can, it's just not sure that someb
Lei Zhang 2012/07/12 02:27:02 Sure, I changed the comment.
+ NOTREACHED();
+ return false;
}
void GtkThemeService::ClearAllThemeData() {

Powered by Google App Engine
This is Rietveld 408576698