Linux: Detect Unity as a desktop environment.

Linux: Detect Unity as a desktop environment.

BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147134

[Lei Zhang, 2012-07-11 18:06:09]

erg: Can you take a look at this CL first? After your approval, I'll ask the
various components owners to take a look.

[Elliot Glaysher, 2012-07-11 19:20:03]

lgtm

[Lei Zhang, 2012-07-12 01:05:08]

Actually, it looks like mdm worked on many of these desktop environment
integration pieces.

[Mike Mammarella, 2012-07-12 01:15:55]

LGTM

https://chromiumcodereview.appspot.com/10735034/diff/11003/base/nix/xdg_util.cc
File base/nix/xdg_util.cc (right):

https://chromiumcodereview.appspot.com/10735034/diff/11003/base/nix/xdg_util....
base/nix/xdg_util.cc:59: }
Looks like in this file we leave these {} off when possible, like here.

https://chromiumcodereview.appspot.com/10735034/diff/11003/chrome/browser/ui/...
File chrome/browser/ui/gtk/gtk_theme_service.cc (right):

https://chromiumcodereview.appspot.com/10735034/diff/11003/chrome/browser/ui/...
chrome/browser/ui/gtk/gtk_theme_service.cc:628: // g++ can't figure out the
switch statement has all cases covered.
Technically, it can, it's just not sure that somebody won't cast a random int to
the enum type and then have it fall out the end of the switch where there's no
return statement.

[Lei Zhang, 2012-07-12 02:27:02]

https://chromiumcodereview.appspot.com/10735034/diff/11003/base/nix/xdg_util.cc
File base/nix/xdg_util.cc (right):

https://chromiumcodereview.appspot.com/10735034/diff/11003/base/nix/xdg_util....
base/nix/xdg_util.cc:59: }
On 2012/07/12 01:15:55, Mike Mammarella wrote:
> Looks like in this file we leave these {} off when possible, like here.

Done.

https://chromiumcodereview.appspot.com/10735034/diff/11003/chrome/browser/ui/...
File chrome/browser/ui/gtk/gtk_theme_service.cc (right):

https://chromiumcodereview.appspot.com/10735034/diff/11003/chrome/browser/ui/...
chrome/browser/ui/gtk/gtk_theme_service.cc:628: // g++ can't figure out the
switch statement has all cases covered.
On 2012/07/12 01:15:55, Mike Mammarella wrote:
> Technically, it can, it's just not sure that somebody won't cast a random int
to
> the enum type and then have it fall out the end of the switch where there's no
> return statement.

Sure, I changed the comment.

[Lei Zhang, 2012-07-12 20:17:23]

sky: OWNERS for content and chrome/browser/ui
willchan: OWNERS for base and net

[Lei Zhang, 2012-07-16 21:23:11]

...and I got no replies because I forgot to email the reviewers. Whoop.

sky, willchan: OWNERS reviews please.

[sky, 2012-07-17 17:48:07]

LGTM

[Ryan Sleevi, 2012-07-17 22:30:37]

net/ LGTM

[Lei Zhang, 2012-07-17 22:41:51]

+brettw for base/ OWNERS.

[brettw, 2012-07-17 22:47:43]

base lgtm