Issue 10735031: Fixing bug with initialization volumes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10735031: Fixing bug with initialization volumes. (Closed)

Created:
8 years, 5 months ago by SeRya

Modified:
8 years, 5 months ago

Reviewers:
Vladislav Kaznacheev, dgozman

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing bug with initialization volumes. Problem was the following. Sometimes mount completed event comes before volume list initialized. In this case DirectoryModel sees that something has changed and the current volume is not mounted. Solution consists in not firing the 'change' event before the volume list has initialized. BUG=135477 TEST=Insert and remove a USB stick several times. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145887

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/resources/file_manager/js/volume_manager.js	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10735031/1

8 years, 5 months ago (2012-07-10 15:01:53 UTC) #3

Change committed as 145887

Expand Messages | Collapse Messages