Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: src/handles.h

Issue 10735024: Output the correct line number in the error message for compilation failures during bootstrapping (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/isolate.cc » ('j') | src/isolate.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 239
240 Handle<Object> SetAccessor(Handle<JSObject> obj, Handle<AccessorInfo> info); 240 Handle<Object> SetAccessor(Handle<JSObject> obj, Handle<AccessorInfo> info);
241 241
242 Handle<FixedArray> AddKeysFromJSArray(Handle<FixedArray>, 242 Handle<FixedArray> AddKeysFromJSArray(Handle<FixedArray>,
243 Handle<JSArray> array); 243 Handle<JSArray> array);
244 244
245 // Get the JS object corresponding to the given script; create it 245 // Get the JS object corresponding to the given script; create it
246 // if none exists. 246 // if none exists.
247 Handle<JSValue> GetScriptWrapper(Handle<Script> script); 247 Handle<JSValue> GetScriptWrapper(Handle<Script> script);
248 248
249 // Script line number computations. 249 // Script line number computations. Note that the line number is zero-based.
250 void InitScriptLineEnds(Handle<Script> script); 250 void InitScriptLineEnds(Handle<Script> script);
251 // For string calculates an array of line end positions. If the string 251 // For string calculates an array of line end positions. If the string
252 // does not end with a new line character, this character may optionally be 252 // does not end with a new line character, this character may optionally be
253 // imagined. 253 // imagined.
254 Handle<FixedArray> CalculateLineEnds(Handle<String> string, 254 Handle<FixedArray> CalculateLineEnds(Handle<String> string,
255 bool with_imaginary_last_new_line); 255 bool with_imaginary_last_new_line);
256 int GetScriptLineNumber(Handle<Script> script, int code_position); 256 int GetScriptLineNumber(Handle<Script> script, int code_position);
257 // The safe version does not make heap allocations but may work much slower. 257 // The safe version does not make heap allocations but may work much slower.
258 int GetScriptLineNumberSafe(Handle<Script> script, int code_position); 258 int GetScriptLineNumberSafe(Handle<Script> script, int code_position);
259 int GetScriptColumnNumber(Handle<Script> script, int code_position); 259 int GetScriptColumnNumber(Handle<Script> script, int code_position);
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 inline NoHandleAllocation(); 323 inline NoHandleAllocation();
324 inline ~NoHandleAllocation(); 324 inline ~NoHandleAllocation();
325 private: 325 private:
326 int level_; 326 int level_;
327 #endif 327 #endif
328 }; 328 };
329 329
330 } } // namespace v8::internal 330 } } // namespace v8::internal
331 331
332 #endif // V8_HANDLES_H_ 332 #endif // V8_HANDLES_H_
OLDNEW
« no previous file with comments | « no previous file | src/isolate.cc » ('j') | src/isolate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698