Issue 10735023: Added Crankshaft support for JavaScript getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10735023: Added Crankshaft support for JavaScript getters. (Closed)

Created:
8 years, 5 months ago by Sven Panne

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Added Crankshaft support for JavaScript getters. Instead of calling the getter via a stub, we now call it more directly via a (guarded) CallConstantFunction instruction. Committed: https://code.google.com/p/v8/source/detail?r=12013

Patch Set 1 #

Total comments: 1

Patch Set 2 : Whitespace changes. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	M	src/hydrogen.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/hydrogen.cc	View	1	2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 5 months ago (2012-07-09 11:21:48 UTC) #2

LGTM with a nit.

http://codereview.chromium.org/10735023/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/10735023/diff/1/src/hydrogen.cc#newcode5671
src/hydrogen.cc:5671: Handle<Object> callback(lookup.GetValueFromMap(*map));
nit: indentation

Expand Messages | Collapse Messages