Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 10735004: Specify path to aidl tool in gyp file (Closed)

Created:
8 years, 5 months ago by Steve Block
Modified:
8 years, 5 months ago
Reviewers:
navabi1, navabi, bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Specify path to aidl tool in gyp file This avoids depending on having $PATH set up correctly when building, which can be problematic when building with the Android build system. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/envsetup.sh View 1 chunk +1 line, -0 lines 0 comments Download
M build/java_aidl.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Steve Block
8 years, 5 months ago (2012-07-04 13:18:13 UTC) #1
bulach
lgtm
8 years, 5 months ago (2012-07-04 14:24:49 UTC) #2
navabi
8 years, 5 months ago (2012-07-09 17:31:48 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698