third_party/android_crazy_linker/src/src/crazy_linker_elf_loader.cpp - Issue 1072533002: crazy linker: convert relocation unpacking to Android style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_elf_loader.cpp

Issue 1072533002: crazy linker: convert relocation unpacking to Android style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updates to gn to match gyp. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/android_crazy_linker/README.chromium ('k') | third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/android_crazy_linker/src/src/crazy_linker_elf_loader.cpp

diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_elf_loader.cpp b/third_party/android_crazy_linker/src/src/crazy_linker_elf_loader.cpp

index a2e5fab23b3f51acd47d6bab8e7b92b8b47b3862..e265ac39b03d5f6f8943614aead26cc0c5ed30c7 100644

--- a/third_party/android_crazy_linker/src/src/crazy_linker_elf_loader.cpp

+++ b/third_party/android_crazy_linker/src/src/crazy_linker_elf_loader.cpp

@@ -193,7 +193,7 @@ bool ElfLoader::ReserveAddressSpace(Error* error) {

return false;

}

- uint8_t* addr = reinterpret_cast<uint8_t*>(min_vaddr);

+ uint8_t* addr = NULL;

int mmap_flags = MAP_PRIVATE | MAP_ANONYMOUS;

// Support loading at a fixed address.