Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 10716003: [Font Settings API]: Rename fontName and localizedName to fontId and displayName (Closed)

Created:
8 years, 5 months ago by falken
Modified:
8 years, 5 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

[Font Settings API]: Rename fontName and localizedName to fontId and displayName This should make the API a little more clear. BUG=114148 TEST=browser tests and sample extension still work Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146295

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -165 lines) Patch
M chrome/browser/extensions/extension_font_settings_api.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/experimental_font_settings.json View 4 chunks +12 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/apps/experimental.bluetooth.html View 1 2 2 chunks +0 lines, -49 lines 0 comments Download
M chrome/common/extensions/docs/apps/experimental.serial.html View 1 4 chunks +84 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/popup.js View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.bluetooth.html View 1 2 2 chunks +0 lines, -49 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.fontSettings.html View 11 chunks +12 lines, -14 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.serial.html View 1 4 chunks +84 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/extensions/docs/static/experimental.fontSettings.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/font_settings/incognito/launch.js View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/test/data/extensions/api_test/font_settings/standard/test.js View 9 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
falken
Hi Matt, Renaming the fontName/localizedName terms was suggested at the API review. What do you ...
8 years, 5 months ago (2012-06-28 08:05:25 UTC) #1
falken
mpcomplete: ping
8 years, 5 months ago (2012-07-11 07:26:04 UTC) #2
Matt Perry
8 years, 5 months ago (2012-07-11 18:35:34 UTC) #3
lgtm. Sorry for the late response, I've been OOO the past 2 weeks.

Powered by Google App Engine
This is Rietveld 408576698