ash/content/display/screen_orientation_controller_chromeos.h - Issue 1071353003: Prevent DisplayPreferences from saving incorrect rotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/content/display/screen_orientation_controller_chromeos.h

Issue 1071353003: Prevent DisplayPreferences from saving incorrect rotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/accelerators/accelerator_controller.cc ('k') | ash/content/display/screen_orientation_controller_chromeos.cc » ('j') | ash/content/display/screen_orientation_controller_chromeos_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/content/display/screen_orientation_controller_chromeos.h

diff --git a/ash/content/display/screen_orientation_controller_chromeos.h b/ash/content/display/screen_orientation_controller_chromeos.h

index aa45734a24d31fad96436bc201a0d255fefbb27c..5097a0147dbaea0455463ccb22a35afa5dbfc4dd 100644

--- a/ash/content/display/screen_orientation_controller_chromeos.h

+++ b/ash/content/display/screen_orientation_controller_chromeos.h

@@ -70,7 +70,8 @@ class ASH_EXPORT ScreenOrientationController

void SetRotationLocked(bool rotation_locked);

// Sets the display rotation and suppresses display notifications.

- void SetDisplayRotation(gfx::Display::Rotation rotation);

+ void SetDisplayRotation(gfx::Display::Rotation rotation,

+ gfx::Display::RotationSource source);

// aura::client::ActivationChangeObserver:

void OnWindowActivated(aura::Window* gained_active,

@@ -102,7 +103,8 @@ class ASH_EXPORT ScreenOrientationController

// Sets the display rotation to |rotation|. Future accelerometer updates

// should not be used to change the rotation. SetRotationLocked(false) removes

// the rotation lock.

- void LockRotation(gfx::Display::Rotation rotation);

+ void LockRotation(gfx::Display::Rotation rotation,

+ gfx::Display::RotationSource source);

// Sets the display rotation based on |lock_orientation|. Future accelerometer

// updates should not be used to change the rotation. SetRotationLocked(false)