chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java - Issue 1071303003: Remove Document mode promo page from First Run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

Issue 1071303003: Remove Document mode promo page from First Run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: aruslan's nits Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunIntroRecentsPage.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

index 0d79ef2eeaf08cdb95dd8348945426b06d3f3c22..d4e64f993824ad598bf654627ca4b7db2c66de32 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

@@ -22,12 +22,6 @@ public interface FirstRunPageDelegate {

void advanceToNextPage();

/**

- * Skips all intro pages.

- * Successfully finishes FRE if there are no non-intro pages.

- */

- void skipIntroPages();

- /**

* Asks to re-instantiate the current page.

* Useful to restore the "clean" state of the UI elements.

@@ -95,9 +89,4 @@ public interface FirstRunPageDelegate {

* @param url Resource id for the URL of the EmbedContentViewActivity.

void showEmbedContentViewActivity(int title, int url);

- /**

- * Opens Chrome preferences for document mode.

- */

- void openDocumentModeSettings();

}