Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 10704259: Added getField/setField to ObjectMirror. For InstanceMirrors, this get/sets (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
===================================================================
--- runtime/lib/mirrors_impl.dart (revision 9823)
+++ runtime/lib/mirrors_impl.dart (working copy)
@@ -105,15 +105,7 @@
// Walk the arguments and make sure they are legal.
for (int i = 0; i < positionalArguments.length; i++) {
var arg = positionalArguments[i];
- if (arg is Mirror) {
- if (arg is! InstanceMirror) {
- throw new MirrorException(
- 'positional argument $i ($arg) was not an InstanceMirror');
- }
- } else if (!isSimpleValue(arg)) {
- throw new MirrorException(
- 'positional argument $i ($arg) was not a simple value');
- }
+ _validateArgument(i, arg);
}
Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
try {
@@ -125,8 +117,51 @@
return completer.future;
}
+ Future<InstanceMirror> getField(String fieldName)
+ {
+ Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
+ try {
+ completer.complete(_getField(this, fieldName));
+ } catch (var exception) {
+ completer.completeException(exception);
+ }
+ return completer.future;
+ }
+
+ Future<InstanceMirror> setField(String fieldName, Object arg)
+ {
+ _validateArgument(0, arg);
+
+ Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
+ try {
+ completer.complete(_setField(this, fieldName, arg));
+ } catch (var exception) {
+ completer.completeException(exception);
+ }
+ return completer.future;
+ }
+
+ static _validateArgument(int i, Object arg)
+ {
+ if (arg is Mirror) {
+ if (arg is! InstanceMirror) {
+ throw new MirrorException(
+ 'positional argument $i ($arg) was not an InstanceMirror');
+ }
+ } else if (!isSimpleValue(arg)) {
+ throw new MirrorException(
+ 'positional argument $i ($arg) was not a simple value');
+ }
+ }
+
static _invoke(ref, memberName, positionalArguments)
native 'LocalObjectMirrorImpl_invoke';
+
+ static _getField(ref, fieldName)
+ native 'LocalObjectMirrorImpl_getField';
+
+ static _setField(ref, fieldName, value)
+ native 'LocalObjectMirrorImpl_setField';
}
// Prints a string as it might appear in dart program text.
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698