Added getField/setField to ObjectMirror. For InstanceMirrors, this get/sets

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 // These values are allowed to be passed directly over the wire.
 bool isSimpleValue(var value) {
   return (value === null || value is num || value is String || value is bool);
 }
@@ skipping 107 matching lines @@
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
       completer.complete(
           _invoke(this, memberName, positionalArguments));
     } catch (var exception) {
       completer.completeException(exception);
     }
     return completer.future;
   }
 
+  Future<InstanceMirror> getField(String fieldName)
+  {
+    Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
+    try {
+      completer.complete(

[turnidge, 2012/07/17 23:59:33]

Can this fit on one line?

+          _getField(this, fieldName));
+    } catch (var exception) {
+      completer.completeException(exception);
+    }
+    return completer.future;
+  }
+
+  Future<InstanceMirror> setField(String fieldName, Object arg)
+  {
+    if (arg is Mirror) {
+      if (arg is! InstanceMirror) {
+        throw new MirrorException(
+            'argument ($arg) was not an InstanceMirror');
+      }
+    } else if (!isSimpleValue(arg)) {
+      throw new MirrorException(
+          'argument ($arg) was not a simple value');

[turnidge, 2012/07/17 23:59:33]

Maybe make a helper function for arg checking to avoid duplicating this code.

+    }
+
+    Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
+    try {
+      completer.complete(

[turnidge, 2012/07/17 23:59:33]

Can this fit on one line?

+          _setField(this, fieldName, arg));
+    } catch (var exception) {
+      completer.completeException(exception);
+    }
+    return completer.future;
+  }
+
   static _invoke(ref, memberName, positionalArguments)
       native 'LocalObjectMirrorImpl_invoke';
+
+  static _getField(ref, fieldName)
+      native 'LocalObjectMirrorImpl_getField';
+
+  static _setField(ref, fieldName, value)
+      native 'LocalObjectMirrorImpl_setField';
 }
 
 // Prints a string as it might appear in dart program text.
 // TODO(turnidge): Consider truncating.
 String _dartEscape(String str) {
   bool isNice(int code) {
     return (code >= 32 && code <= 126);
   }
 
   StringBuffer buf = new StringBuffer();
@@ skipping 357 matching lines @@
 
   // Creates a new local InstanceMirror
   static InstanceMirror makeLocalInstanceMirror(Object reflectee)
       native 'Mirrors_makeLocalInstanceMirror';
 
   // Creates a new local mirror for some Object.
   static InstanceMirror mirrorOf(Object reflectee) {
     return makeLocalInstanceMirror(reflectee);
   }
 }