Add extension permissions for Media Gallery API.

chrome/common/extensions/permissions/api_permission.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/permissions/api_permission.h"
 
 #include "chrome/common/extensions/permissions/permissions_info.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ skipping 81 matching lines @@
       IDS_EXTENSION_PROMPT_WARNING_BROWSING_HISTORY,
       PermissionMessage::kBrowsingHistory },
     { kKeybinding, "keybinding" },
     { kIdle, "idle" },
     { kInput, "input", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_INPUT,
       PermissionMessage::kInput },
     { kManagement, "management", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_MANAGEMENT,
       PermissionMessage::kManagement },
+    { kMediaGalleries, "mediaGalleries" },
+    { kMediaGalleriesRead, "mediaGalleriesRead" },

[Matt Perry, 2012/07/24 00:21:07]

Does the read permission have no warning message?

[vandebo (ex-Chrome), 2012/07/24 00:32:57]

No - By itself it only conveys permission to request permission for galleries at
runtime (instead of install time).  (aa@ et al are aware of this concept and
signed off on it.)

     { kPageCapture, "pageCapture", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_ALL_PAGES_CONTENT,
       PermissionMessage::kAllPageContent },
     { kPrivacy, "privacy", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_PRIVACY,
       PermissionMessage::kPrivacy },
     { kStorage, "storage" },
     { kTab, "tabs", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_TABS,
       PermissionMessage::kTabs },
@@ skipping 48 matching lines @@
     { kAudioCapture, "audioCapture", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_AUDIO_CAPTURE,
       PermissionMessage::kAudioCapture },
     { kVideoCapture, "videoCapture", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_VIDEO_CAPTURE,
       PermissionMessage::kVideoCapture },
     { kFileSystem, "fileSystem" },
     { kFileSystemWrite, "fileSystemWrite", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_FILE_SYSTEM_WRITE,
       PermissionMessage::kFileSystemWrite },
+    { kMediaGalleriesAccessEverything, "mediaGalleriesAccessEverything",

[Matt Perry, 2012/07/24 00:21:07]

I don't see this actually used in this CL. What does it do? The name is a bit
confusing. Does it just combine read/write?

[vandebo (ex-Chrome), 2012/07/24 00:32:57]

Sorry, working on another CL to hook this up.  In the long run this will
probably remain a platform app only permission (whereas read, write, append will
be available for regular extensions). This permission will grant access to all
of the users media galleries without further prompting.  It will be
read/write/append access depending on the the other media gallery permissions.

Commentary: I'd be happy to add comments in the code explaining how/what these
permissions do, but it doesn't seem to be the norm.

[Matt Perry, 2012/07/24 00:51:20]

maybe mediaGalleriesAllGalleries then? Agreed that adding a comment here is
unusual.

[vandebo (ex-Chrome), 2012/07/24 01:07:59]

Done.

+      kFlagCannotBeOptional,
+      IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_ACCESS_EVERYTHING,
+      PermissionMessage::kMediaGalleriesAccessEverything },
   };
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(PermissionsToRegister); ++i) {
     const PermissionRegistration& pr = PermissionsToRegister[i];
     info->RegisterPermission(
         pr.id, pr.name, pr.l10n_message_id,
         pr.message_id ? pr.message_id : PermissionMessage::kNone,
         pr.flags);
   }
 
   // Register aliases.
   info->RegisterAlias("unlimitedStorage", kOldUnlimitedStoragePermission);
   info->RegisterAlias("tabs", kWindowsPermission);
   // TODO(mihaip): Should be removed for the M20 branch, see
   // http://crbug.com/120447 for more details.
   info->RegisterAlias("background", kTemporaryBackgroundAlias);
 }
 
 }  // namespace extensions