Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Side by Side Diff: chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js

Issue 10704258: Add extension permissions for Media Gallery API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove the permissions that aren't ready yet Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom bindings for the Media Gallery API. 5 // Custom bindings for the Media Gallery API.
6 6
7 var mediaGalleriesNatives = requireNative('experimental_mediaGalleries'); 7 var mediaGalleriesNatives = requireNative('experimental_mediaGalleries');
8 8
9 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden(); 9 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
10 10
11 chromeHidden.registerCustomHook('experimental.mediaGalleries', 11 chromeHidden.registerCustomHook('experimental.mediaGalleries',
12 function(bindingsAPI, extensionId) { 12 function(bindingsAPI, extensionId) {
13 var apiFunctions = bindingsAPI.apiFunctions; 13 var apiFunctions = bindingsAPI.apiFunctions;
14 14
15 // getMediaFileSystems uses a custom callback so that it can instantiate and 15 // getMediaFileSystems uses a custom callback so that it can instantiate and
16 // return an array of file system objects. 16 // return an array of file system objects.
17 apiFunctions.setCustomCallback('getMediaFileSystems', 17 apiFunctions.setCustomCallback('getMediaFileSystems',
18 function(name, request, response) { 18 function(name, request, response) {
19 var result = []; 19 var result = null;
20 for (var i = 0; i < response.length; i++) { 20 if (response != undefined) {
Evan Stade 2012/07/23 23:51:06 I think if (response) is fine. If you have to chec
vandebo (ex-Chrome) 2012/07/24 00:00:38 Done.
21 result.push( 21 result = [];
22 mediaGalleriesNatives.GetMediaFileSystemObject(response[i].fsid, 22 for (var i = 0; i < response.length; i++) {
23 response[i].dirname)); 23 result.push(mediaGalleriesNatives.GetMediaFileSystemObject(
24 response[i].fsid, response[i].dirname));
25 }
24 } 26 }
25 if (request.callback) 27 if (request.callback)
26 request.callback(result); 28 request.callback(result);
27 request.callback = null; 29 request.callback = null;
28 }); 30 });
29 31
30 // extractEmbeddedThumbnails uses a renderer side handler so that it can 32 // extractEmbeddedThumbnails uses a renderer side handler so that it can
31 // synchronously return a result. The result object's state is computable 33 // synchronously return a result. The result object's state is computable
32 // from the function's input. 34 // from the function's input.
33 apiFunctions.setHandleRequest('extractEmbeddedThumbnails', 35 apiFunctions.setHandleRequest('extractEmbeddedThumbnails',
34 function(fileEntry) { 36 function(fileEntry) {
35 return mediaGalleriesNatives.ExtractEmbeddedThumbnails(fileEntry); 37 return mediaGalleriesNatives.ExtractEmbeddedThumbnails(fileEntry);
36 }); 38 });
37 }); 39 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698