Add extension permissions for Media Gallery API.

chrome/common/extensions/permissions/api_permission.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/permissions/api_permission.h"
 
 #include "chrome/common/extensions/permissions/permissions_info.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ skipping 80 matching lines @@
       IDS_EXTENSION_PROMPT_WARNING_BROWSING_HISTORY,
       PermissionMessage::kBrowsingHistory },
     { kKeybinding, "keybinding" },
     { kIdle, "idle" },
     { kInput, "input", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_INPUT,
       PermissionMessage::kInput },
     { kManagement, "management", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_MANAGEMENT,
       PermissionMessage::kManagement },
+    { kMediaGalleries, "mediaGalleries" },

[Evan Stade, 2012/07/18 05:11:00]

no messages?

also is it documented somewhere what these mean?

[vandebo (ex-Chrome), 2012/07/18 22:43:32]

Specifying the mediaGalleries permission only makes it possible to call the
functions, you won't get any access unless you specify either read or write. 
Then, even in that case, it still requires a runtime permission grant to get any
access.  I initially had messages but decided that the runtime request made them
unnecessary. i.e. geo permission is runtime and there's not install time message
 (an imperfect analogy since it's not an extension API).
 
Not yet.  It will go into the API docs.

[Evan Stade, 2012/07/19 00:33:38]

I think that you only want read and write and not to have mediaGalleries.
PermissionSet::HasAccessToFunction seems like the place to do hack this in.
yea, for extensions we want install-time messages rather than use-time requests.
(I had to add this for WebRTC for example, another html5 api that was popping up
an infobar.) However the configuration UI is unavoidable in this case so what
you have here is ok. We just need to make sure that the UI has different text
for read and write.

[vandebo (ex-Chrome), 2012/07/19 04:51:53]

I was going to update the extension permission system i.e. PermissionSet to make
the permissions more direct, but aa@ suggested doing this instead.  He just
forwarded you that thread for other reasons.
 
Agreed.

+    { kMediaGalleriesRead, "mediaGalleriesRead" },
+    { kMediaGalleriesWrite, "mediaGalleriesWrite" },
     { kPageCapture, "pageCapture", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_ALL_PAGES_CONTENT,
       PermissionMessage::kAllPageContent },
     { kPrivacy, "privacy", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_PRIVACY,
       PermissionMessage::kPrivacy },
     { kStorage, "storage" },
     { kTab, "tabs", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_TABS,
       PermissionMessage::kTabs },
@@ skipping 48 matching lines @@
     { kAudioCapture, "audioCapture", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_AUDIO_CAPTURE,
       PermissionMessage::kAudioCapture },
     { kVideoCapture, "videoCapture", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_VIDEO_CAPTURE,
       PermissionMessage::kVideoCapture },
     { kFileSystem, "fileSystem" },
     { kFileSystemWrite, "fileSystemWrite", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_FILE_SYSTEM_WRITE,
       PermissionMessage::kFileSystemWrite },
+    { kMediaGalleriesDefaultAll, "mediaGalleriesDefaultAll",

[vandebo (ex-Chrome), 2012/07/17 23:36:56]

I'm not sure what to call this permission. Regular extensions won't get access
to any media galleries by default, the user will have to configure/approve
access to them in the constrained dialog.  However, platform apps can specify
this permission to get access to all configured galleries by default, hence
"DefaultAll."

[Evan Stade, 2012/07/18 05:11:00]

maybe platform apps shouldn't have to specify this permission at all, but just
get it by virtue of being a platform app that has mediaGalleriesRead. I mean
people just click through the permissions prompt anyway. Perhaps the onus of
acting responsibly should be on the app's shoulders.

but setting that aside I would call this mediaGalleriesAccessEverything

[vandebo (ex-Chrome), 2012/07/18 22:43:32]

Maybe I could be convinced of this concept, but most of the platform app only
permissions have messages so it sounds like a question to bring up in a larger
context.
 
Done.

+      kFlagCannotBeOptional,
+      IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_DEFAULT_ALL,
+      PermissionMessage::kMediaGalleriesDefaultAll },
   };
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(PermissionsToRegister); ++i) {
     const PermissionRegistration& pr = PermissionsToRegister[i];
     info->RegisterPermission(
         pr.id, pr.name, pr.l10n_message_id,
         pr.message_id ? pr.message_id : PermissionMessage::kNone,
         pr.flags);
   }
 
   // Register aliases.
   info->RegisterAlias("unlimitedStorage", kOldUnlimitedStoragePermission);
   info->RegisterAlias("tabs", kWindowsPermission);
   // TODO(mihaip): Should be removed for the M20 branch, see
   // http://crbug.com/120447 for more details.
   info->RegisterAlias("background", kTemporaryBackgroundAlias);
 }
 
 }  // namespace extensions