Add extension permissions for Media Gallery API.

chrome/browser/extensions/api/media_gallery/media_gallery_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Media Galleries API.
 
 #include "chrome/browser/extensions/api/media_gallery/media_gallery_api.h"
 
 #include <string>
 #include <vector>
@@ skipping 10 matching lines @@
 #endif
 
 namespace extensions {
 
 using chrome::MediaFileSystemRegistry;
 using content::ChildProcessSecurityPolicy;
 
 GetMediaFileSystemsFunction::~GetMediaFileSystemsFunction() {}
 
 bool GetMediaFileSystemsFunction::RunImpl() {
+  bool read_permission = GetExtension()->HasAPIPermission(
+      extensions::APIPermission::kMediaGalleriesRead);
+  bool write_permission = GetExtension()->HasAPIPermission(
+      extensions::APIPermission::kMediaGalleriesWrite);
+  if (!read_permission && !write_permission) {
+    base::ListValue* list = new base::ListValue();
+    SetResult(list);

[Evan Stade, 2012/07/18 05:11:00]

I think the typical thing is SetResult(false). Also you want to set error_ to
something useful.

[vandebo (ex-Chrome), 2012/07/18 22:43:32]

Done.

+    return true;
+  }
+
   const content::RenderProcessHost* rph = render_view_host()->GetProcess();
   chrome::MediaFileSystemRegistry* media_fs_registry =
       MediaFileSystemRegistry::GetInstance();
   const std::vector<MediaFileSystemRegistry::MediaFSIDAndPath> filesystems =
       media_fs_registry->GetMediaFileSystems(rph);
 
   const int child_id = rph->GetID();
   base::ListValue* list = new base::ListValue();
   for (size_t i = 0; i < filesystems.size(); i++) {
     // TODO(thestig) Check permissions to file systems when that capability
     // exists.
     const MediaFileSystemRegistry::MediaFSIDAndPath& fsid_and_path =
         filesystems[i];
     const std::string& fsid = fsid_and_path.first;
     const FilePath& path = fsid_and_path.second;
 
     base::DictionaryValue* dict_value = new base::DictionaryValue();
     dict_value->SetWithoutPathExpansion(
         "fsid", Value::CreateStringValue(fsid));
     // The directory name is not exposed to the js layer.
     dict_value->SetWithoutPathExpansion(
         "dirname", Value::CreateStringValue("_"));
     list->Append(dict_value);
 
-    content::ChildProcessSecurityPolicy* policy =
-        ChildProcessSecurityPolicy::GetInstance();
-    if (!policy->CanReadFile(child_id, path))
-      policy->GrantReadFile(child_id, path);
-    policy->GrantReadFileSystem(child_id, fsid);
+    if (read_permission) {
+      content::ChildProcessSecurityPolicy* policy =
+          ChildProcessSecurityPolicy::GetInstance();
+      if (!policy->CanReadFile(child_id, path))
+        policy->GrantReadFile(child_id, path);
+      policy->GrantReadFileSystem(child_id, fsid);
+    }
+    // TODO(vandebo) Handle write permission.
   }
 
   SetResult(list);
   return true;
 }
 
 OpenMediaGalleryManagerFunction::~OpenMediaGalleryManagerFunction() {}
 
 bool OpenMediaGalleryManagerFunction::RunImpl() {
   // TODO(vandebo) Open the Media Gallery Manager UI.
   SetResult(Value::CreateNullValue());
   return true;
 }
 
 AssembleMediaFileFunction::~AssembleMediaFileFunction() {}
 
 bool AssembleMediaFileFunction::RunImpl() {
   // TODO(vandebo) Update the metadata and return the new file.
   SetResult(Value::CreateNullValue());
   return true;
 }
 
 }  // namespace extensions