Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 10704242: Fix 6 failures in net unittests on Android (Closed)

Created:
8 years, 5 months ago by yongsheng
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org, darin-cc_chromium.org, wtc, rkn
Visibility:
Public.

Description

Fix 6 failures in net unittests on Android These 6 failures are due to enable persistent session cookies: 1) Cookie without expiry time is persistent; 2) Cookie without expiry time is persistent so that the add/delete command will be pushed back into the command list of cookie store. BUG= TEST=net_unittests; run_tests.py -s net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147159

Patch Set 1 #

Patch Set 2 : Fix other 4 failures #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M build/android/gtest_filter/net_unittests_disabled View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 1 7 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
yongsheng
please help review it. for the 4 failures, i'm investigating them. will upload the patch ...
8 years, 5 months ago (2012-07-17 07:28:46 UTC) #1
yongsheng
On 2012/07/17 07:28:46, yongsheng wrote: > please help review it. > for the 4 failures, ...
8 years, 5 months ago (2012-07-17 11:51:24 UTC) #2
John Grabowski
Android LGTM Be sure to get a net/ LGTM
8 years, 5 months ago (2012-07-17 16:25:14 UTC) #3
erikwright (departed)
LGTM.
8 years, 5 months ago (2012-07-17 19:49:58 UTC) #4
yongsheng
On 2012/07/17 19:49:58, erikwright wrote: > LGTM. thanks, so I think you're the owner of ...
8 years, 5 months ago (2012-07-17 23:42:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10704242/4001
8 years, 5 months ago (2012-07-18 00:05:41 UTC) #6
commit-bot: I haz the power
Failed to apply patch for build/android/gtest_filter/net_unittests_disabled: While running patch -p1 --forward --force; patching file build/android/gtest_filter/net_unittests_disabled ...
8 years, 5 months ago (2012-07-18 00:05:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10704242/14001
8 years, 5 months ago (2012-07-18 00:17:07 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-18 01:49:30 UTC) #9
Change committed as 147159

Powered by Google App Engine
This is Rietveld 408576698