Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 10704231: Merge trunk r145370 to the 21.0.1180 branch. (Closed)

Created:
8 years, 5 months ago by Mark Mentovai
Modified:
8 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Merge trunk r145370 to the 21.0.1180 branch. Supply an explicit designated requirement for all internal components during signing. The implied designated requirement produced when signing on Lion cannot be satisfied on pre-Lion systems. This was already addressed by providing an explicit designated requirement for the outer .app bundle. This change also provides an explicit designated requirement for inner components. The Parental Controls feature apparently requires an application to meet its designated requirement. Since the requirement for inner components such as the helper would never be met on 10.6 (or presumably 10.5), it was impossible to launch such inner components. This prevented any renderer processes from ever starting up. The user would only see sad tabs and endless OS prompts, and the browser would effectively be useless. BUG=131682, 134311 TEST=Turn on Parental Controls and set it to limit applications. Launch Chrome. After a possible initial prompt asking whether Chrome should be permitted (authenticate and say yes), Chrome should function normally. There should be no prompts about Chrome Helper, Chrome Helper EH, or Chrome Helper NP. Web pages should load normally. There should be no sad tabs. Note that there may still be a prompt about ksadmin. Review URL: https://chromiumcodereview.appspot.com/10696101 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/installer/mac/sign_versioned_dir.sh.in View 1 chunk +16 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mark Mentovai
8 years, 5 months ago (2012-07-16 19:10:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698