Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Unified Diff: runtime/vm/code_generator.cc

Issue 10704216: Fix type checking of void type. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/byte_array.dart ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 9671)
+++ runtime/vm/code_generator.cc (working copy)
@@ -586,11 +586,13 @@
}
-// For error reporting simplify type name, e.g, all integer types (Smi, Mint,
-// Bigint) a re reported as 'int'.
+// For error reporting, simplify type name, e.g, all integer types (Smi, Mint,
+// Bigint) are reported as 'int' and all String types are mapped to 'String'.
static RawString* GetSimpleTypeName(const Instance& value) {
if (value.IsInteger()) {
return String::NewSymbol("int");
+ } else if (value.IsString()) {
+ return String::NewSymbol("String");
} else {
return Type::Handle(value.GetType()).Name();
}
« no previous file with comments | « runtime/lib/byte_array.dart ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698