runtime/vm/stub_code_x64.cc - Issue 10704210: Fix problem of excessive attempts to optimize, fix excessive deoptimizations for load/store indexed…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 10704210: Fix problem of excessive attempts to optimize, fix excessive deoptimizations for load/store indexed… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_x64.cc

===================================================================

--- runtime/vm/stub_code_x64.cc (revision 9677)

+++ runtime/vm/stub_code_x64.cc (working copy)

@@ -1536,8 +1536,9 @@

if (FlowGraphCompiler::CanOptimize()) {

__ cmpq(FieldAddress(RCX, Function::usage_counter_offset()),

Immediate(FLAG_optimization_counter_threshold));

- Label not_yet_hot;

- __ j(LESS_EQUAL, &not_yet_hot, Assembler::kNearJump);

+ Label not_yet_hot, already_optimized;

+ __ j(LESS, &not_yet_hot, Assembler::kNearJump);

+ __ j(GREATER, &already_optimized, Assembler::kNearJump);

AssemblerMacros::EnterStubFrame(assembler);

__ pushq(RBX); // Preserve inline cache data object.

__ pushq(R10); // Preserve arguments array.

@@ -1548,6 +1549,7 @@

__ popq(RBX); // Restore inline cache data object.

__ LeaveFrame();

__ Bind(&not_yet_hot);

+ __ Bind(&already_optimized);

}

ASSERT(num_args > 0);

// Get receiver (first read number of arguments from argument descriptor array

« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | no next file » | no next file with comments »