Issue 10704208: Some misc gyp fix-up for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704208: Some misc gyp fix-up for Android (Closed)

Created:
8 years, 5 months ago by Yaron

Modified:
8 years, 5 months ago

Reviewers:
John Grabowski, brettw

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Some misc gyp fix-up for Android 1) Disable fPIC 2) Disable manpage 3) Disable conditions with linux_use_tcmalloc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146666

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	chrome/chrome_exe.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	6 chunks	+6 lines, -6 lines	1 comment	Download
M	ppapi/ppapi.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/mesa/mesa.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

non-pp LGTM http://codereview.chromium.org/10704208/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/10704208/diff/1/chrome/chrome_tests.gypi#newcode836 chrome/chrome_tests.gypi:836: ['os_posix == 1 and OS != "mac" ...

8 years, 5 months ago (2012-07-13 18:19:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10704208/1

8 years, 5 months ago (2012-07-13 20:45:01 UTC) #4

Change committed as 146666

Expand Messages | Collapse Messages