Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 10704189: Revert 12069: Implements a new API to set a function entry hook for profiling (Closed)

Created:
8 years, 5 months ago by danno
Modified:
8 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Revert 12069: Implements a new API to set a function entry hook for profiling Reverted due to waterfall failures TBR=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -337 lines) Patch
M include/v8.h View 2 chunks +4 lines, -36 lines 0 comments Download
M src/api.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-stubs.h View 2 chunks +1 line, -33 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -105 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Michael Starzinger
8 years, 5 months ago (2012-07-12 16:31:43 UTC) #1
LGTM (rubber-stamped).

Powered by Google App Engine
This is Rietveld 408576698