Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: src/objects.cc

Issue 10704185: When we find an accessor pair as TRANSITION, we are sure it doesn't contain an accessor yet. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index a98387cc325e7b39cc553aa2459089bdbdbaaddd..fb2ad7fee2122c605c4e94019138b322b8fc471a 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -2904,16 +2904,8 @@ MaybeObject* JSObject::SetPropertyForResult(LookupResult* result,
Object* transition = result->GetTransitionValue();
if (transition->IsAccessorPair()) {
- if (!AccessorPair::cast(transition)->ContainsAccessor()) {
- return self->ConvertDescriptorToField(*name,
- *value,
- attributes);
- }
- return self->SetPropertyWithCallback(transition,
- *name,
- *value,
- result->holder(),
- strict_mode);
+ ASSERT(!AccessorPair::cast(transition)->ContainsAccessor());
+ return ConvertDescriptorToField(*name, *value, attributes);
}
Map* transition_map = Map::cast(transition);
@@ -3037,6 +3029,7 @@ MaybeObject* JSObject::SetLocalPropertyIgnoreAttributes(
Object* transition = result.GetTransitionValue();
if (transition->IsAccessorPair()) {
+ ASSERT(!AccessorPair::cast(transition)->ContainsAccessor());
return ConvertDescriptorToField(name, value, attributes);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698